Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove peak watcher groups #1014

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ScottChesworth
Copy link
Collaborator

This improves parity of the Peak Watcher GUI across screen readers by removing group prompts that weren't being reported consistently.

@ScottChesworth
Copy link
Collaborator Author

@jennykbrennan, can you give this a spin with VoiceOver?

@ScottChesworth
Copy link
Collaborator Author

ScottChesworth commented Mar 8, 2024

If someone sighted can give Peak Watcher a quick check before we merge this I'd appreciate it. Maybe @AZSlow3 or @mespotine? I've had sighted verification along the way that nothing is obscured or wildly broken, but only on a basic small screen. The eyes that have verified aren't in the head of a human who's used to placing controls without a framework doing most of the heavy lifting, because they've only worked in UX after 1993.

Steps:

  1. Install OSARA from the AppVeyor comment above.
  2. In REAPER, hit Control+T to insert a new track, type a name for it and hit Enter.
  3. Now hit Alt+W, choose first watcher from the context menu. Or if you don't use the OSARA key map, run this action: OSARA: Configure Peak Watcher for current track/track FX (depending on focus)
  4. Tell me if anything is super weird/non-standard about that GUI.

if(above = true && you = hasTime) {
HELP? // lol
}

@jennykbrennan
Copy link
Contributor

@ScottChesworth I've just sent you a recording of how it behaves.

Hint, it's a bit of a mess so it's easier to show than explain.

@mespotine
Copy link

@ScottChesworth
Which action is run with Alt+W?

@ScottChesworth
Copy link
Collaborator Author

I updated the comment above with the name of the action. Hold off on checking it out though, turns out I've only made things worse with VoiceOver screen reader so far hahaha. I'll tag you again when I've figured out how to do something that works better.

@jcsteh
Copy link
Owner

jcsteh commented Mar 11, 2024

I don't understand how this made things worse. Does SWELL not label the controls with the text next to the control?

@ScottChesworth
Copy link
Collaborator Author

Seems not. I probably need to fire up a Mac VM to muck about with it, but that's a bit of a task to get going on Ryzen.

@jcsteh
Copy link
Owner

jcsteh commented Mar 11, 2024

So what happens exactly? Are the controls all unlabelled or...?

@mespotine
Copy link

mespotine commented Mar 11, 2024 via email

@ScottChesworth
Copy link
Collaborator Author

On Windows, everything seems to be ok with Osara and NVDA.

Yeah already checked that, thanks. The question is does the GUI look ok? It's basic, but is positioning of controls sensible, is it intuitive to use with a mouse? We're checking the visual UX because there are a handful of people who do have some amount of sight that they'll use in conjunction with a screen reader, someone probably will try to operate this GUI with a mouse at some point.

@ScottChesworth
Copy link
Collaborator Author

So what happens exactly? Are the controls all unlabelled or...?

Labels are scattered all over the shop. @jennykbrennan , can you post what the VO cursor finds moving from left to right, and also what gets reported as you move through the tab order there?

@jcsteh
Copy link
Owner

jcsteh commented Mar 11, 2024

I expect the VO cursor might be a bit messed up based on what you've said in the past about SWELL and control ordering, but I would have thought the controls themselves would be labelled correctly. Otherwise, wouldn't that be broken right across the shop with REAPER in general? It's the same toolkit; I don't think we're doing anything special.

@jennykbrennan
Copy link
Contributor

Note that what's labeled radio buttons here do not behave as such. They work as check boxes. But that is not anything new. It's been like that for as long as I've used it.

Peak watcher Track 1

VO navigation left to right:.
Follow when last track changes Checkbox unchecked
Do not hold Radiobutton
Level type
peak db popup button
Hold until reset Selected radio button
Watch channel 1 Checkbox checked
Hold for time in ms radio button.
Watch channel two checkbox checked
Set hold time
Dim text
When level reaches
0.0 Edit text
Reset Button
OK Button
Cancel Button
Disable Button

Tab order left to right
Follow when last track changes checkbox Checked
Do not hold radio button
Peak db popup button
Hold until reset radio button
Watch channel 1 Checkbox checked
Hold for time in ms radio button
Watch channel 2 Checkbox checked
0.0 edit text
Reset Button
OK Button
Cancel Button
Disable Button

@jcsteh
Copy link
Owner

jcsteh commented Mar 12, 2024

Urgh, I really don't understand how it even comes up with that order. That's not even how they're ordered visually.

That said, although the order is very screwed up, nothing seems outright wrong with the labelling here. Am I missing something?

@jcsteh
Copy link
Owner

jcsteh commented Mar 12, 2024

Oh, the text boxes not being labelled isn't great. The label immediately precedes them with the VO cursor, but the controls really should get a label. Hmm.

@mespotine
Copy link

mespotine commented Mar 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants