Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up renv in this project #26

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

egnor
Copy link
Contributor

@egnor egnor commented Aug 11, 2023

I don't know what you think about renv but I find it absolutely invaluable for library development, to avoid depending on a global R environment and its unpredictable contents.

(If you're not into it, then I'll just use it locally! Maybe you'd let me at least add its files to .gitignore in that case.)

@egnor
Copy link
Contributor Author

egnor commented Aug 11, 2023

Added a reference to bunny (and improved the .Rprofile logic to be more robust) to fix #28

@jcpsantiago
Copy link
Owner

jcpsantiago commented Aug 11, 2023

I use it on all my projects actually, but usually skip it for libraries (I added it to some though). I don't see any problems with adding it. Thanks!

I'm waiting for this repo to be transfered to my personal account, I'll merge this as soon as that happens (ETA today or tomorrow)

@egnor
Copy link
Contributor Author

egnor commented Aug 11, 2023

CI failures --

MacOS: This looks unrelated to this change?? Maybe related to the old setup-r@v1 action?
image

Ubuntu (both versions): This is definitely related to this change, strange how it's not able to use the Remotes:? Looking into that.
image

@egnor
Copy link
Contributor Author

egnor commented Aug 12, 2023

Running rcmdcheck in my local environment works fine:

image

Again, maybe an issue with the older versions of the R workflow actions?

@jcpsantiago jcpsantiago merged commit 654d4ce into jcpsantiago:master Aug 13, 2023
1 of 4 checks passed
@jcpsantiago
Copy link
Owner

@egnor I think so, they haven't been updated in aaages... something TODO, especially now that there's commit activity again (thanks for that BTW :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants