Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Webpack2 for pr 142 144 145 #146

Open
wants to merge 2 commits into
base: webpack2
Choose a base branch
from

Conversation

Falieson
Copy link
Contributor

webpack2 soft changes for PRs #142 #144 #145

almost the same thing as what I submitted to master in those PRs but included link to setup "autochange to node6"

upgrade packages 20170422

  • went through and upgraded packages that were behind master
  • npm run test fails on branch master before I made any changes to the package.json
  • npm run test:dev passes

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.63% when pulling f051aaa on Falieson:webpack2_for-pr_142-144-145 into 2b97ce0 on jcoreio:webpack2.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.63% when pulling f051aaa on Falieson:webpack2_for-pr_142-144-145 into 2b97ce0 on jcoreio:webpack2.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.63% when pulling f051aaa on Falieson:webpack2_for-pr_142-144-145 into 2b97ce0 on jcoreio:webpack2.

@jedwards1211
Copy link
Member

@Falieson sweet, thanks! Greenkeeper is getting kind of annoying, I wish I had a script to just periodically make PRs with all deps upgraded at once.

@jedwards1211
Copy link
Member

Hmmm I'm on the fence about .nvmrc though. Some users may want to run it with different versions of node, and that would practically force them to run it with 6.10. Let's keep .nvmrc out of this repo, of course you can still have it and gitignore it in your own working copy

@Falieson
Copy link
Contributor Author

sounds good - I'll get you those updates and do another update for the readme with a recommendation for the nvm and autoswitching

@Falieson
Copy link
Contributor Author

Falieson commented May 2, 2017

Going to wait until #142 and #144 are resolved to update this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants