Changed API to pirateweather.net #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as described here: jclarke0000#36 (comment) You'll need to update your readme.md to reflect the new weather data provider.
|
Think this Project is dead. Maybe Time for a fork. |
|
Yeah, I feared as much. Unfortunately, I have more of a passive understanding of coding than an active one (and I've never really actively used Github before). That being said, I did fork this module and implement the API change to pirateweather.net. If you're interested, have a look here: https://github.com/dankerthrone/MMM-PirateSkyForecast Should I update the MMM wiki to point to my fork? |
|
Yeah you can add your module in wiki I think. I would leave the "old" entry there anyway. Maybe update the npm dependencies before this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as described here: #36 (comment) You'll need to update your readme.md to reflect the new weather data provider.