Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add processing response #11

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Add processing response #11

merged 4 commits into from
Nov 21, 2023

Conversation

Flip120
Copy link
Contributor

@Flip120 Flip120 commented Nov 21, 2023 •
edited
Loading

  • Store the request as processing before executing the code and return a processing response (102 http status code)
  • Store the response and remove the processing status to the document
  • Removed the random idempotency key as is not necessary now

Fix #10

Flip120
Flip120 commented Nov 21, 2023
View reviewed changes
README.md Show resolved Hide resolved
Flip120
Flip120 commented Nov 21, 2023
View reviewed changes
lib/grape/idempotency.rb Outdated Show resolved Hide resolved
jcagarcia
jcagarcia reviewed Nov 21, 2023
View reviewed changes
lib/grape/idempotency.rb Outdated Show resolved Hide resolved
jcagarcia
jcagarcia reviewed Nov 21, 2023
View reviewed changes
lib/grape/idempotency.rb Outdated Show resolved Hide resolved
@jcagarcia jcagarcia linked an issue Nov 21, 2023 that may be closed by this pull request
Two requests with idempotency key are performing the code when one of the requests didn't finish yet #10
Closed
@Flip120 Flip120 marked this pull request as ready for review November 21, 2023 15:42
@jcagarcia jcagarcia merged commit 4b25062 into jcagarcia:main Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcagarcia jcagarcia jcagarcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two requests with idempotency key are performing the code when one of the requests didn't finish yet
2 participants
@Flip120 @jcagarcia