-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of TODIM 🆕 #57
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 96.66% 96.76% +0.10%
==========================================
Files 42 43 +1
Lines 1767 1823 +56
==========================================
+ Hits 1708 1764 +56
Misses 59 59 ☔ View full report in Codecov by Sentry. |
Please do not merge this until I tackle the missing lines according to Codecov's report. |
Thank you, it seems it works well. I won't have an action until you ping me. Please also note that the file https://github.com/jbytecode/JMcDM/blob/main/src/normalizations.jl includes some common standardization methods. MCDM tools now have optional normalization arguments with default values like function topsis(
decisionMat::Matrix,
weights::Array{Float64,1},
fns::Array{F,1};
normalization::G = Normalizations.vectornormnormalization
)::TopsisResult where {F<:Function, G<:Function} would you mind migrating the normalization of todim to normalizations.jl or use an existing one if there is one with the same functionality? |
Sure! I'll check it out. |
+ `normalizedAMatrix!` removed 🧹 + Normalizations employed 🔧 + `normalization` kwarg added in accordance with jbytecode#57 (comment)
@jbytecode, Could you please review the changes? Please let me know if there is anything else to be considered. |
looks nice, thank you! |
This PR delivers the implementation of the TODIM method as promised in #48. Please review the changes and inform me if there are any issues related to the implementation, unit tests, or any other concerns. Additionally, please let me know if adjustments need to be made to other files to align them with the package's API.