Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder organization and enable github action #66

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

WisdomToNorth
Copy link
Contributor

@WisdomToNorth WisdomToNorth commented Aug 7, 2024

  • Copy the API headers to build/include, making it easier for API users
  • Enable GitHub Actions on Windows, Mac, and Linux
  • Temporarily disable unit tests combine_plines_test, cavc_get_extents, and combine_with_self_invariants which are currently failing

@jbuckmccready
Copy link
Owner

I think changes mostly makes sense but without cavc in the directory path it makes it less clear when including headers in c++ and the c api header shouldn't be in a src directory.

Probably should follow something like what is suggested here (note use of named directory in path for namespace/library clarity): https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1204r0.html#intro

- Enable github action in Win/Mac/Linux
- Organization test folders, temporarily disable unit tests combine_plines_test, cavc_get_extents, and combine_with_self_invariants which are currently failing
@WisdomToNorth
Copy link
Contributor Author

WisdomToNorth commented Aug 8, 2024

Thank you for the feedback. I agree with your points and have made the necessary adjustments to the commit. Please review the changes, thanks!

@jbuckmccready jbuckmccready merged commit 4dcfe08 into jbuckmccready:master Aug 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants