Fixed recursive fetch when new url is unchanged #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR ready? I'm experiencing the same issue and would love to have the new version with fixes included! |
amoran
reviewed
Aug 1, 2020
index.js
Outdated
| @@ -443,8 +443,10 @@ const getPodcastFromURL = exports.getPodcastFromURL = async function (url, param | |||
| const feedResponse = await fetchFeed(url) | |||
| const channel = feedResponse.rss.channel[0] | |||
|
|
|||
| if (channel["itunes:new-feed-url"]) { | |||
| return await getPodcastFromURL(channel["itunes:new-feed-url"][0], params) | |||
| const newURL = channel["itunes:new-feed-url"][0] | |||
There was a problem hiding this comment.
If there is no property "itunes:new-feed-url", accessing the 0th element will fail.
added null check
|
Thanks @doeixd for working on this--I ran into this bug today and had to patch my local version. It looks like the Travis CI build failed b/c of the optional chaining syntax ( If you remove that syntax, I bet it will be merged w/out issues. In fact, this PR could be a one liner, e.g. if (channel["itunes:new-feed-url"] && channel["itunes:new-feed-url"][0] !== url) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, the script will infinitely fetch this podcast this pr will fix that