Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose IDisposables in NativePdbWriter #952

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dispose IDisposables in NativePdbWriter #952

wants to merge 1 commit into from

Commits on Jun 20, 2024

  1. Dispose IDisposables in NativePdbWriter 

    - The code creates a local variable that's an IDisposable
  (CustomMetadataWriter), but doesn't call Dispose() on it.

- The CustomMetadataWriter class holds two IDisposables (MemoryStream
  and BinaryStreamWriter), but was only Dispose()ing one of them.
    @omajid
    omajid committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2afc92b View commit details
    Browse the repository at this point in the history