Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement build independent hash #618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Mono.Cecil.PE/Image.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ sealed class Image : IDisposable {

public Disposable<Stream> Stream;
public string FileName;
public int FileChecksumPosition;

public ModuleKind Kind;
public string RuntimeVersion;
Expand All @@ -40,6 +41,7 @@ sealed class Image : IDisposable {

public uint EntryPointToken;
public uint Timestamp;
public int TimestampPosition;
public ModuleAttributes Attributes;

public DataDirectory Win32Resources;
Expand Down
4 changes: 3 additions & 1 deletion Mono.Cecil.PE/ImageReader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ void ReadImage ()
ushort sections = ReadUInt16 ();

// TimeDateStamp 4
image.TimestampPosition = (int)BaseStream.Position;
image.Timestamp = ReadUInt32 ();
// PointerToSymbolTable 4
// NumberOfSymbols 4
Expand Down Expand Up @@ -130,7 +131,7 @@ void ReadOptionalHeaders (out ushort subsystem, out ushort dll_characteristics)

// ImageBase 4 || 8
// SectionAlignment 4
// FileAlignement 4
// FileAlignment 4
// OSMajor 2
// OSMinor 2
// UserMajor 2
Expand All @@ -147,6 +148,7 @@ void ReadOptionalHeaders (out ushort subsystem, out ushort dll_characteristics)
// HeaderSize 4
// FileChecksum 4
Advance (16);
image.FileChecksumPosition = (int)(BaseStream.Position - 4);

// SubSystem 2
subsystem = ReadUInt16 ();
Expand Down
1 change: 1 addition & 0 deletions Mono.Cecil/AssemblyReader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,7 @@ public ModuleDefinition Populate (ModuleDefinition module)
Advance (2); // Generation

module.Name = ReadString ();
module.MvidPosition = position;
module.Mvid = ReadGuid ();

return module;
Expand Down
26 changes: 26 additions & 0 deletions Mono.Cecil/ModuleDefinition.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
using System;
using System.Collections.Generic;
using System.IO;
using System.Security.Cryptography;
using System.Threading;
using SR = System.Reflection;

Expand Down Expand Up @@ -252,6 +253,7 @@ public sealed class ModuleDefinition : ModuleReference, ICustomAttributeProvider
ModuleAttributes attributes;
ModuleCharacteristics characteristics;
Guid mvid;
internal int MvidPosition;

internal ushort linker_version = 8;
internal ushort subsystem_major = 4;
Expand Down Expand Up @@ -1159,6 +1161,30 @@ public void Write (Stream stream, WriterParameters parameters)
}
}

public static class ModuleDefinitionExtensions {

// See: https://groups.google.com/forum/#!topic/mono-cecil/AGq0LfBdqjo
public static byte [] GetBuildIndependentHash (this ModuleDefinition moduleDefinition, HashAlgorithm hashAlgorithm)
{
var buffer = File.ReadAllBytes (moduleDefinition.Image.FileName);

// Overwrite parts of the assembly file content byte array (only in memory of course)
// that change on every build with an empty byte array, and thus make it comparable

Buffer.BlockCopy (new byte [sizeof (uint)], 0, buffer, moduleDefinition.Image.TimestampPosition, sizeof(uint));
Buffer.BlockCopy (new byte [sizeof (uint)], 0, buffer, moduleDefinition.Image.FileChecksumPosition, sizeof(uint));
Buffer.BlockCopy (new byte [moduleDefinition.Image.GuidHeap.IndexSize], 0, buffer, moduleDefinition.MvidPosition, moduleDefinition.Image.GuidHeap.IndexSize);

return hashAlgorithm.ComputeHash (buffer);
}

internal static byte [] GetBuildDependentHash (this ModuleDefinition moduleDefinition, HashAlgorithm hashAlgorithm)
{
var buffer = File.ReadAllBytes (moduleDefinition.Image.FileName);
return hashAlgorithm.ComputeHash (buffer);
}
}

static partial class Mixin {

public enum Argument {
Expand Down