Skip to content

Make dll.h compatible with -fvisibility=hidden #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make dll.h compatible with -fvisibility=hidden #958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions include/yaml-cpp/dll.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,22 @@

#ifdef YAML_CPP_DLL // Using or Building YAML-CPP DLL (definition defined
// manually)

#if defined(_WIN32) || defined(WIN32)
# define YAML_CPP_API_IMPORT __declspec(dllimport)
# define YAML_CPP_API_EXPORT __declspec(dllexport)
#else
# define YAML_CPP_API_IMPORT __attribute__((visibility("default")))
# define YAML_CPP_API_EXPORT __attribute__((visibility("default")))
#endif

#ifdef yaml_cpp_EXPORTS // Building YAML-CPP DLL (definition created by CMake
// or defined manually)
// #pragma message( "Defining YAML_CPP_API for DLL export" )
#define YAML_CPP_API __declspec(dllexport)
#define YAML_CPP_API YAML_CPP_API_EXPORT
#else // yaml_cpp_EXPORTS
// #pragma message( "Defining YAML_CPP_API for DLL import" )
#define YAML_CPP_API __declspec(dllimport)
#define YAML_CPP_API YAML_CPP_API_IMPORT
#endif // yaml_cpp_EXPORTS
#else // YAML_CPP_DLL
#define YAML_CPP_API
Expand Down