DecodeBase64 returns empty string on *all* errors #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It already returns an empty string if it encounters an invalid character. However, if, instead, it has an incomplete set of characters, it currently returns a truncated result. Instead, it detects truncation and returns the empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It already returns an empty string if it encounters an invalid character. However, if, instead, it has an incomplete set of characters (no-multiple of four), it currently returns a truncated result. Instead, it detects truncation and returns the empty string.
The only time
DecodeBase64()returns a valid empty return value is if the input was likewise empty.