Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add send_batch method to NlSocketHandles #271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add send_batch method to NlSocketHandles #271

wants to merge 1 commit into from

Conversation

LogicalOverflow
Copy link

This is the easy part of #270, adding a method that allows sending multiple Nlmsghdr in a single socket send call.

I am not sure if you want &[Nlmsghdr] for the interface, or if something else would be nicer.

@jbaublitz jbaublitz mentioned this pull request Feb 25, 2025
Open
@jbaublitz jbaublitz added this to the neli-0.7.1 milestone Feb 25, 2025
@jbaublitz jbaublitz self-requested a review February 25, 2025 19:59
jbaublitz
jbaublitz requested changes Feb 27, 2025
View reviewed changes
Copy link
Owner

@jbaublitz jbaublitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a test for each method? I'm trying to be a little more careful about making sure that new code is tested while I work my way back through untested code and add new tests. After that, this should be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaublitz jbaublitz jbaublitz requested changes

Assignees

@LogicalOverflow LogicalOverflow

Labels
enhancement
Projects
None yet
Milestone
neli-0.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@LogicalOverflow @jbaublitz