WIP: Handle broken metadata by discarding package, or give a useful error #2119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2118, but no tests yet (hence WIP).
After this change, a requirements file is generated by discarding the problematic package.
Now, with this in requirements.txt:
I get:
The exception is still shown. Also we log a warning to tell the user the package was discarded.
The way to find the offending pacakge is crude (regex in error message string).
When the regex search for package name fails, we re-raise the error so no requirements file is generated.
In that case we log an error, which is hopefully helpful.
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.