-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ordering of format controls to preserve behavior of pip #2082
Conversation
@sethmlarson this looks good but could you rewrite the test to use parametrize? It seems to me that this is smashing to standalone tests into the same function which is discouraged. |
Thanks for the review @webknjaz, I've restructured the test to use parametrization :) |
@sethmlarson could you fix the linting offenses (change lists to tuples in tests). I'll enable auto-merge, meanwhile. |
Head branch was pushed to by a user without write access
@webknjaz Looks like automerge gets disabled if I push, you might have to enable again. |
No problem! The CI run also needed approval. |
Looks like compatibility with Pip's |
72cbcea
to
d4d5fd4
Compare
Thanks for the fix and merge. We're seeing Dependabot open PRs that break the ordering preventing pip installing successfully. It would be great to have a pip-tools release, would it be possible to make one soon? Thanks! |
I don't have enough privileges for this. cc @atugushev |
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.Closes #2081