Conditions addition to insert_row
#1359
Open
+8
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditions the addition to
insert_row
withincreate_historical_record_m2ms
in order to respectexcluded_field_kwargs
viaself.field_excluded_kwargs
.This change necessarily undoes the addition of
through_model_field_names = [f.name for f in through_model._meta.fields]
which is not compatible with the api ofself.field_excluded_kwargs
.Description
See #1358
Related Issue
#1358
Motivation and Context
#1358
How Has This Been Tested?
Yes, I run it in prod.
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit run
command to format and lint.AUTHORS.rst
CHANGES.rst