Deprecate StateLog model, to instead, bring your own model. #176
Conversation
ticosax
force-pushed
the
gh-133-state-lessmodels
branch
from
b548639
to
7173f17
Compare
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
- Coverage 97.28% 97.02% -0.26%
==========================================
Files 24 25 +1
Lines 516 572 +56
==========================================
+ Hits 502 555 +53
- Misses 14 17 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ticosax
force-pushed
the
gh-133-state-lessmodels
branch
2 times, most recently
from
be8f775
to
f8c879f
Compare
| ``` | ||
|
|
||
| Additionally you'd want to migrate the data from django_fsm_log.models.StateLog to your new table. |
There was a problem hiding this comment.
Would be nice to have an example/snippet here that can be used as a base.
There was a problem hiding this comment.
Sure, it could be a nice addition, If I have to go through that path. I'll add it.
As of today I don't have incentive to migrate to an internal concrete model within the projects I maintain. It will come at some point, probably not as part of this PR though.
| "\nPlease check the documentation at https://django-fsm-log.readthedocs.io/en/latest/" | ||
| "\nto know how to.", |
There was a problem hiding this comment.
| "\nPlease check the documentation at https://django-fsm-log.readthedocs.io/en/latest/" | |
| "\nto know how to.", | |
| "\nSee the documentation at https://django-fsm-log.readthedocs.io/en/latest/.", |
There was a problem hiding this comment.
TODO: use more specific link.
This is an implementation that support the idea exposed in jazzband#133 It's still a Draft, I'm open for any feedback more specifically around the names. Not tested yet with a real project. It's meant to be completely backward compatible.
Co-authored-by: Daniel Hahler <[email protected]>
Co-authored-by: Daniel Hahler <[email protected]>
Co-authored-by: Daniel Hahler <[email protected]>
Co-authored-by: Daniel Hahler <[email protected]>
Co-authored-by: Daniel Hahler <[email protected]>
Co-authored-by: Daniel Hahler <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Daniel Hahler <[email protected]>
Co-authored-by: Daniel Hahler <[email protected]>
ticosax
force-pushed
the
gh-133-state-lessmodels
branch
from
39ac59d
to
9262180
Compare
ticosax
changed the title
|
What happened with this? 👀 |
|
@ticosax , do you need some help finishing this PR? |
|
@thomasmassmann If I recall correctly, I left it in an alpha state. It's meant to be testable with existing projects. Unfortunately I'm not using Django at the moment, which means I can't commit time to it. But hopefully this work can be continued by more contributors. |
I’m working on a bigger Django project where I would like to use it and would need those changes being available. Depending on the importance of this for the stakeholders, I could be stepping in in the second half of this year. What would be your preferred way for contribution? Continue in your fork or create a new fork of your changes? |
I don't want to stay in the way. I think it's preferable that you clone the PR and then you re-submit a new PR from your fork. As long as you keep attributions to my identity, make the process as easy as you'd like. |
This is an implementation that support the idea exposed in #133
It's still a Draft, I'm open for any feedback more specifically around the names. Not tested yet with a real project.
It's meant to be completely backward compatible.