Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/Spec fixes & Restore original flash message behavior #6

Merged
merged 8 commits into from
Dec 22, 2024

Conversation

jayywolff
Copy link
Owner

@jayywolff jayywolff commented Dec 21, 2024

  • 51606b2 Bugfix to not return any users when the mobile phone number is missing when querying for a user with User.find_by_mobile_phone
  • Fixed test coverage from the initial fork from Authy to Twilio Verify API
  • Disabled specs for TOTP setup. Currently there's just a method exposed to generate a code with the Twilio Verify service. Rails apps consuming the gem are expected to to generate a qr code with this code and present it to the user to scan. This feature can be added in the future
  • Restored original flash message behavior from authy-devise on a few endpoints. Despite this being the original behavior, Due to this change I will bump versioning as minor version release for Rails apps that did not migrate from devise-authy
  • Added dev support for ruby 3.4

…rposes but

no need to index it since its no longer relevant
coverage for TOTP setup, this functionality isnt present at the moment can be added in a future release
generate a code with the Twilio Verify service. Rails apps consuming the gem are expected to to generate a qr code with this code and present it to the user to scan. This feature can be added in the future
@jayywolff jayywolff merged commit 38b6825 into master Dec 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant