Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible solution to the issue I filed at jaywcjlove/react-hotkeys#29
This change starts from an empty
_downKeys
array in case a key wasn't cleared (e.g. no key up is fired on mac for cmd+up)It will work given:
dispatch
function rebuilds_downKeys
to include correct modifiersThere are other changes that could be made given that we start from an empty
_downKeys
array, but this seemed like a good start and doesn't break any tests.