Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added share button in each card #598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fernandojbf123
Copy link

Hello my friend,

  • I just added the share button in each card as requested.
  • Created a modal window that activates when you press the button. The modal is similar to youtube's share buttom and it uses components so in the future you might want to add more social media share buttoms.
  • Added some css to make it look nicer.
  • Added social media icons.

Hoping you like it,
Best regards,
Fernando

@vercel
Copy link

vercel bot commented Aug 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-resource-hub ❌ Failed (Inspect) Aug 6, 2023 1:31am
web-resources-project ❌ Failed (Inspect) Aug 6, 2023 1:31am
web-resources-project-qa ❌ Failed (Inspect) Aug 6, 2023 1:31am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Fernandojbf123! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project. We'll review your changes and provide feedback as soon as possible. Keep up the great work!

@tanujbordikar
Copy link

hey @Fernandojbf123, I think that there is a small mistake. This issue was first raised by me and also the author has assigned me to this issue as you can see and check #584 !

@Fernandojbf123
Copy link
Author

Hello my friend @jayk-gupta. Yeah, so sorry for the miss understanding. If you like the way i code it, use it and publish, no problem at all 😄
Best regards,
Fernando

@jayk-gupta
Copy link
Owner

Hello my friend,

  • I just added the share button in each card as requested.
  • Created a modal window that activates when you press the button. The modal is similar to youtube's share buttom and it uses components so in the future you might want to add more social media share buttoms.
  • Added some css to make it look nicer.
  • Added social media icons.

Hoping you like it, Best regards, Fernando

Can you share a small video of the changes you made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants