Skip to content

fix: remove edit block from reference documentation - #19

Open
msvticket wants to merge 12 commits into
mainfrom
remove-edit-from-generated
Open

fix: remove edit block from reference documentation#19
msvticket wants to merge 12 commits into
mainfrom
remove-edit-from-generated

Conversation

@msvticket

@msvticket msvticket commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

I'm removing the links to edit page hierarchies that are generated / imported from outside of jx-docs:

Following the documentation for docsy/hugo didn't work because we use such old versions.

So I updated hugo and docsy and on the way removed a lot our overrides to partials and replaced with the same functionality from docsy. I removed Google Tag manager with Google analytics since we don't have access to that anyway.

The functionality that was replaced with upstreams solutions are:

  • Dark / Light switch
  • Algolia search
  • Chroma syntax highlighting
  • Style edit page box
  • Mermaid

To get both the JayeX and CDFoundation logos in the top left I created an SVG combining them.

While at it I did a few small fixes I noticed while working

  • Changed where to create issues for feedback to the jx repo. I never enabled issues on jx-docs since the TOC has decided that we only want issues in the jx and lighthouse repos.

TODO

@jenkins-x-bot

jenkins-x-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
The changes made require 1 more approval(s).
To complete the pull request process, please assign msvticket
You can assign the PR to them by writing /assign @msvticket in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot

jenkins-x-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@msvticket
msvticket force-pushed the remove-edit-from-generated branch 3 times, most recently from 662566d to 1e5cf2a Compare August 4, 2026 15:17
@jenkins-x-bot

jenkins-x-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

1 similar comment
@jenkins-x-bot

jenkins-x-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@msvticket
msvticket force-pushed the remove-edit-from-generated branch from 1e5cf2a to e6ee430 Compare August 4, 2026 15:30
@jenkins-x-bot

jenkins-x-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@msvticket
msvticket force-pushed the remove-edit-from-generated branch from 6e33d1d to 43f6a65 Compare August 4, 2026 17:09
@msvticket

msvticket commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@msvticket
msvticket force-pushed the remove-edit-from-generated branch 3 times, most recently from 235adb2 to 4a593dd Compare August 4, 2026 17:25
@jenkins-x-bot

jenkins-x-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@msvticket
msvticket force-pushed the remove-edit-from-generated branch from 4a593dd to d461ca3 Compare August 4, 2026 18:27
@msvticket
msvticket force-pushed the remove-edit-from-generated branch from d0ce3b4 to 0247792 Compare August 4, 2026 21:29
@msvticket

msvticket commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@msvticket
msvticket force-pushed the remove-edit-from-generated branch 2 times, most recently from 6dfa052 to d335880 Compare August 4, 2026 22:16
@jenkins-x-bot

jenkins-x-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

1 similar comment
@jenkins-x-bot

jenkins-x-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@msvticket
msvticket force-pushed the remove-edit-from-generated branch from 4a4bab8 to bebebc1 Compare August 4, 2026 22:41
@jenkins-x-bot

jenkins-x-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@msvticket
msvticket force-pushed the remove-edit-from-generated branch from bebebc1 to 155c488 Compare August 4, 2026 22:49
@jenkins-x-bot

jenkins-x-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

5 similar comments
@jenkins-x-bot

jenkins-x-bot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@jenkins-x-bot

jenkins-x-bot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@jenkins-x-bot

jenkins-x-bot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@jenkins-x-bot

jenkins-x-bot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@jenkins-x-bot

jenkins-x-bot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@msvticket
fix: upgrade hugo and themes
2175416 
revert to default theme functionality
join logos (while preserving link to cd.foundation work)
switch to official image
remove edit block from reference documentation
@msvticket
fix: add svg favicon
bec9dd4
@msvticket
fix: remove broken links
747bfe9
@msvticket
fix: enable stadard dark mode
2d1bf25 
removing unused custom styling and code
@msvticket
fix: remove unneccesary overrides
b42607e
@msvticket
fix: configure edit section
b0d71a1
@msvticket
fix: enable emojis
e99697b
@msvticket
fix: direct issues to main repo
95c0c41
@msvticket
fix: make whole cd logo clickable
f7b51ca 
doesn't work in firefox though
@msvticket
msvticket force-pushed the remove-edit-from-generated branch from 3ede0af to f7b51ca Compare September 1, 2026 16:17
@jenkins-x-bot

jenkins-x-bot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@msvticket
fix: update version directly in partial
4b55470 
avoid unnecessary complexity and risk for conflicts
@jenkins-x-bot

jenkins-x-bot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

1 similar comment
@jenkins-x-bot

jenkins-x-bot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@msvticket
msvticket force-pushed the remove-edit-from-generated branch from 6f7e5de to 21e4293 Compare September 1, 2026 16:46
@jenkins-x-bot

jenkins-x-bot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

@jenkins-x-bot

jenkins-x-bot commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

⭐ PR built and available in a preview jayex-io-jx-docs-pr-19 here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msvticket @jenkins-x-bot