Remove flowmc for now#70
Open
ColCarroll wants to merge 1 commit intojax-ml:mainfrom
Open
Conversation
|
While I am trying to keep to the API changes to minimal, nonetheless I will have to refactor some changes in keywords under the hood. For this reason, I think it would be better to wait for 1.0, which I hope to get it going within this year. I will open a PR when it is ready. Is this https://github.com/jax-ml/bayeux/blob/main/bayeux/_src/mcmc/flowmc.py the only flowMC related file? |
Collaborator
Author
|
Thanks, @kazewong ! Totally understand, and saw the warning in your README. I would expect you could just undo the changes in this PR and work from there if you (or anyone else!) decided to pick this up in the future. |
|
@ColCarroll I would like to know if you're interested in merging this PR as the answer to it will be related to how we tackle bambinos/bambi#906 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying API changed, and it is unclear how to fix things cleanly. @kazewong happy to accept fixes, either now or once a 1.0 is released, but it has been hard keeping up with changes so far!