add css support! #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuhsinFatih
commented
Oct 21, 2020
| css: css => { css.write('dist/bundle.css'); } | ||
| }), | ||
| svelte({ customElement: false, exclude: /\.wc\.svelte$/, | ||
| css: css => { css.write('dist/bundle.css'); } |
There was a problem hiding this comment.
actually I just noticed that this one is overwriting the bundle.css file generated per line 18. I don't know how to merge these styles
There was a problem hiding this comment.
what if I don't want to emit css file? we want to inline the styles in the style tag
There was a problem hiding this comment.
That would be great but I don't know how that can be done. This is sort of a hack I think. I'm only vaguely familiar with custom elements
There was a problem hiding this comment.
There is a kind of hack here: https://github.com/redradix/svelte-custom-element-template
But seems to be challenging to upgrade to the latest svelte loader...
If you find a way, I will be more than happy to use it 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds custom css for components. It is scoped to component like in regular svelte components. The components in the example are each updated to have their own custom styles.
Here is the end result:
