-
Notifications
You must be signed in to change notification settings - Fork 892
WIP: Modernize project and add Vite, Vitest & Eslint 🚧 #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
javve
wants to merge
43
commits into
master
Choose a base branch
from
vite-vitest
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x tests and sort code
…but allow node 6 via package.json)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #785 +/- ##
==========================================
- Coverage 93.54% 88.94% -4.61%
==========================================
Files 19 21 +2
Lines 837 1438 +601
Branches 199 0 -199
==========================================
+ Hits 783 1279 +496
- Misses 38 159 +121
+ Partials 16 0 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long time no see! I began a project four years ago to refactor the code base, the purpose was to decouple the different modules a bit and allow unit tests for each part of List.js. Unfortunately I lost momentum and the project died.
Now I've had some extra time on my hands and took the opportunity to continue the work, and as part of that I've also taken the time to modernize the project a bit. I've thrown out Webpack, Jest & Babel to replace with Vite, Vitest & Eslint.