Skip to content

WIP: Modernize project and add Vite, Vitest & Eslint 🚧 #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 43 commits into
base: master
Choose a base branch
from

Conversation

javve
Copy link
Owner

@javve javve commented Apr 25, 2025

Long time no see! I began a project four years ago to refactor the code base, the purpose was to decouple the different modules a bit and allow unit tests for each part of List.js. Unfortunately I lost momentum and the project died.

Now I've had some extra time on my hands and took the opportunity to continue the work, and as part of that I've also taken the time to modernize the project a bit. I've thrown out Webpack, Jest & Babel to replace with Vite, Vitest & Eslint.

  • Webpack ➡️ Vite
  • Jest ➡️ Viteest
  • Circle CI ➡️ GitHub Action
  • 🆕 Eslint
  • ❎ Bower

javve added 30 commits November 22, 2020 14:15
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2025

Codecov Report

Attention: Patch coverage is 95.47872% with 17 lines in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (d32c85d) to head (a00d8e4).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/index.js 79.71% 14 Missing ⚠️
src/sort-buttons.js 97.61% 2 Missing ⚠️
src/templater.js 99.05% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
- Coverage   93.54%   88.94%   -4.61%     
==========================================
  Files          19       21       +2     
  Lines         837     1438     +601     
  Branches      199        0     -199     
==========================================
+ Hits          783     1279     +496     
- Misses         38      159     +121     
+ Partials       16        0      -16     
Flag Coverage Δ
unittests 88.94% <95.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/fuzzy-search.js 100.00% <100.00%> (ø)
src/item.js 100.00% <100.00%> (ø)
src/parse.js 100.00% <100.00%> (ø)
src/search.js 100.00% <100.00%> (+3.52%) ⬆️
src/sort.js 100.00% <100.00%> (+3.07%) ⬆️
src/utils/classes.js 61.48% <ø> (+2.65%) ⬆️
src/utils/value-names.js 100.00% <100.00%> (ø)
src/templater.js 99.23% <99.05%> (+0.07%) ⬆️
src/sort-buttons.js 97.61% <97.61%> (ø)
src/index.js 76.28% <79.71%> (-22.51%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants