JavaScript Animations #136
Conversation
|
|
|
Please make the requested changes. After it, add a comment "/done". |
|
Hi, Karla! Doing fine? Please don't translate or change the source code in the examples. Could you take a look into that? Like, you should keep the ';', spaces and variable names. Cheers! |
Hey, yeah. I'm addressing feedback now. My linter changed the code, fixing that :) |
|
/done |
|
Hi @karlasamantha would you please also resolve the conflicts, or kindly inform if unavailable to? Thank you. |
|
Hi @karlasamantha , please I wonder if you could resolve the conflicts, or kindly inform if unavailable to? Thank you. |
Hi @odsantos , sorry for the delay! I'll try to fix the conflicts today! |
|
/done |
|
/done |
|
Hi @karlasamantha , thank you. |
There was a problem hiding this comment.
Hi @karlasamantha ,
The article review is still missing, hopefully to another time.
Please, feel free to leave a note on something you may not agree.
Thank you.
|
Please make the requested changes. After it, add a comment "/done". |
There was a problem hiding this comment.
Hi @karlasamantha ,
Here is the whole review.
Please, feel free to leave a note where you might not agree.
Thank you,
Osvaldo.
|
Please make the requested changes. After it, add a comment "/done". |
|
Hello @karlasamantha the English article was updated and this PR now has some conflicts. The changes are small, though. Thank you. |
karlasamantha
force-pushed
the
javascript-animations
branch
from
eb41b5e
to
7c7e1a4
Compare
karlasamantha
force-pushed
the
javascript-animations
branch
from
7c7e1a4
to
c1f4878
Compare
karlasamantha
requested review from
odsantos and
wnleao
and removed request for
wnleao and
odsantos
|
/done |
|
@odsantos, @jonnathan-ls, @Peruibeloko, what do you recommend colleagues to be done in this pull request? |
|
@karlasamantha, are you available to update and apply the changes requested? |
@nazarepiedady sure, but I don't see any pending changes requested. Am I missing something here? |
|
@karlasamantha, I would like to invite you to compare the original English content to the Portuguese content translated by you to see if there are any updates needed or sentences that need to be applied. I also invite you to check if the reviews did by @odsantos are observed or resolved. |
|
@jonnathan-ls, do you have time to review and handle this pull request? |
No description provided.