Iterables

[marcoarib]

No description provided.

[CLAassistant]

All committers have signed the CLA.

[wnleao]

Hey, Marco! Could you join all commits in only 1?

[wnleao]

Btw, did you check if the english version had changes? Some pt-br articles are way back... https://github.com/javascript-tutorial/en.javascript.info

[marcoarib]

Hey, Marco! Could you join all commits in only 1?

How can I do that? I'm not familiarized with Github editing.
Thanks.

[wnleao]

Hey, Marco! Could you join all commits in only 1?

How can I do that? I'm not familiarized with Github editing.
Thanks.

No problem. Are you using the command line? Check out this link: https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

[wnleao]

Also, I've seen in your translation that you're translating code aswell. We should keep the source code as in the original and only translate comments.

[wnleao]

Later on, whenever you want to change your last commit, like picking up from where you left off, you should use git commit --amend check out more details in https://www.atlassian.com/br/git/tutorials/rewriting-history

[marcoarib]

Hey, Marco! Could you join all commits in only 1?

How can I do that? I'm not familiarized with Github editing.
Thanks.

No problem. Are you using the command line? Check out this link: https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

I'm using browser.

[wnleao]

Hey, marco! Could you finish up reviewing #121 ? I've already done a thorough review and Ana already changed what had to be changed. We need 2 people to review n order to approve the PR. Cheers!

[wnleao]

Hey, Marco! Could you join all commits in only 1?

How can I do that? I'm not familiarized with Github editing.
Thanks.

No problem. Are you using the command line? Check out this link: https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

I'm using browser.

I don't know how to squash commits using github site, but let me know when you're done and I'll try to squash your commits over here. Ok?

[odsantos]

Hi @marcoarib please could you also resolve the conflicts? Thank you.

[odsantos]

Hi @marcoarib , "Object.keys, values, entries" is not part of "Iterables".
Would you remove it from this Pull Request and create a separate one for it?
Would you also resolve the conflicts?
Thanks.

[nazarepiedady]

@Peruibeloko, @jonnathan-ls, @odsantos, we need some solution to this pull request. I am thinking on to close it and start a new one with updates applied and conflicts resolved.

[Peruibeloko]

@nazarepiedady I'll fork and update it