Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to ECMA-262 specification #3691

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sneeed
Copy link

@sneeed sneeed commented May 9, 2024

old link was broken

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label May 9, 2024
@javascript-translate-bot javascript-translate-bot requested a review from a team May 9, 2024 13:41
@CLAassistant
Copy link

CLAassistant commented May 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@Afirestriker Afirestriker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels May 14, 2024
@slevithan
Copy link

This PR is incorrect. It arbitrarily links to the ancient v5.1 of the spec.

The current link is fine. It just redirects to https://ecma-international.org/publications-and-standards/standards/ecma-262/

Three options:

  1. Keep the current link, which redirects.
  2. Update to the new URL (redirect target).
  3. Use https://tc39.es/ecma262/ which is always the most up-to-date ECMAScript spec (including any finished proposals).

Any of the above seem okay, but not accepting this PR as is.

@@ -5,7 +5,7 @@ This book is a *tutorial*. It aims to help you gradually learn the language. But

## Specification

[The ECMA-262 specification](https://www.ecma-international.org/publications/standards/Ecma-262.htm) contains the most in-depth, detailed and formalized information about JavaScript. It defines the language.
[The ECMA-262 specification](https://262.ecma-international.org/5.1/) contains the most in-depth, detailed and formalized information about JavaScript. It defines the language.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should link to the latest standard, not v5.1 from 2011.

@javascript-translate-bot javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label Jun 18, 2024
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@sneeed
Copy link
Author

sneeed commented Jun 18, 2024

/done

Thanks for the feedback.

I think your option 3 would be best and changed it accordingly.

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs +1 One more review needed review needed Review needed, please approve or request changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants