Output destination can be dynamically determined from the task #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osdakira
force-pushed
the
output-redirect-on-demand
branch
from
56160a2 to
e4243f7
Compare
|
Hi @bragamat |
hey @benlangfeld can you review it or merge it please ? 😄 |
|
Just needs a changelog entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want different tasks to output to different logs.
Different tasks should output to different logs.
Currently, we have to write :output for each task, which is not DRY.
Since :output can be written dynamically, we can change the output destination dynamically by passing tasks to it.
However, since lambda requires an argument, changing it will break the existing code.
On the other hand, proc works without arguments, so we can use tasks as arguments only for proc to maintain backward compatibility.