Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the option to open images loaded from remote URL in the second window(s) #44

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added the option to open images loaded from remote URL in the second window(s) #44

wants to merge 5 commits into from

Conversation

Mimetus
Copy link

@Mimetus Mimetus commented Jun 7, 2024

Pull Request Description

This PR adds the option to open images from remote URLs in the second windows panes.

Changes Proposed

  • Added mouse listener events to identify target of editor context menu
  • Added listener to editor context menu that adds "Second Window" options to the context menu if the target was an image.
  • Refactored some code to reduce duplication.

Screenshots

image

@Mimetus
Copy link
Author

Mimetus commented Jun 8, 2024

@valentine195 / @sigrunixia, let me know if this change makes sense

@Mimetus
Copy link
Author

Mimetus commented Sep 26, 2024

@valentine195 ping for review. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mimetus