Skip to content

Conversation

Emiliopg91
Copy link

Device class:

  • 'Enabled' flag for device. if is setted to false, packages led/zone update packages wont be sent saving CPU and network usage

RGBColor class:

  • toHex method to get hex string representation of color
  • toHsv method to get equivalent HSV representation of RGB color
  • mul method to multiply RGB componentes with a number between 0 and 1. Useful to dim colors, which is required to "apply brightness"

@jath03
Copy link
Owner

jath03 commented Apr 20, 2025

I like the changes listed, but there are a lot of unrelated changes in styling. Can you clean up the PR to only include the listed changes and keep styling consistent with the rest of the project?

Another change I'd prefer, which is a bit of a nitpick, but instead of

if enabled:
    # do thing

I'd prefer

if not enabled:
    return
# do thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants