Skip to content

Conversation

@jasonyuezhang
Copy link
Owner

This updates the message for the situation where logs performed a full scan and no user query was specified.


Copied from getsentry#102141
Original PR: getsentry#102141

This updates the message for the situation where logs performed a full scan and
no user query was specified.
@propel-test-bot propel-test-bot bot changed the title chore(logs): Update message for logs full scan no query chore(logs): Update full-scan message when no user query is provided Oct 27, 2025
@propel-test-bot
Copy link

Add hasUserQuery prop to improve log scan messaging

Small UI tweak in the logs Explore view. Adds a new boolean prop hasUserQuery so that the confidence footer can differentiate between full-scan results with and without a user-supplied search query. Message copy is updated accordingly.

Key Changes

• Added hasUserQuery to ConfidenceFooterProps and ConfidenceMessageProps
• Prop is wired from logsGraph.tsx via useQueryParamsQuery()
• Conditional text branch in ConfidenceMessage for dataScanned === 'full' && !hasUserQuery returning simplified count strings
• Updated i18n copy strings for the new branch

Affected Areas

static/app/views/explore/logs/confidenceFooter.tsx
static/app/views/explore/logs/logsGraph.tsx

This summary was automatically generated by @propel-code-bot

chartInfo={chartInfo}
isLoading={timeseriesResult.isLoading}
rawLogCounts={rawLogCounts}
hasUserQuery={!!userQuery}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BestPractice]

The hasUserQuery prop is passed as !!userQuery but this will be true for any non-empty string, including whitespace-only queries. Consider using a more robust check:

Suggested change
hasUserQuery={!!userQuery}
hasUserQuery={!!(userQuery && userQuery.trim())}

Committable suggestion

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Context for Agents
[**BestPractice**]

The `hasUserQuery` prop is passed as `!!userQuery` but this will be `true` for any non-empty string, including whitespace-only queries. Consider using a more robust check:

```suggestion
            hasUserQuery={!!(userQuery && userQuery.trim())}
```

⚡ **Committable suggestion**

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

File: static/app/views/explore/logs/logsGraph.tsx
Line: 209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants