Skip to content

fix(aci): link Create Monitor button to monitor creation page #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(aci): link Create Monitor button to monitor creation page #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions static/app/views/automations/components/editConnectedMonitors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {Fragment, useRef, useState} from 'react';
import styled from '@emotion/styled';

import {Button} from 'sentry/components/core/button';
import {LinkButton} from 'sentry/components/core/button/linkButton';
import {Flex} from 'sentry/components/core/layout';
import useDrawer from 'sentry/components/globalDrawer';
import {DrawerHeader} from 'sentry/components/globalDrawer/components';
Expand All @@ -21,6 +22,8 @@ import usePageFilters from 'sentry/utils/usePageFilters';
import ConnectedMonitorsList from 'sentry/views/automations/components/connectedMonitorsList';
import {DetectorSearch} from 'sentry/views/detectors/components/detectorSearch';
import {makeDetectorListQueryKey, useDetectorsQuery} from 'sentry/views/detectors/hooks';
import {useMonitorViewContext} from 'sentry/views/detectors/monitorViewContext';
import {makeMonitorCreatePathname} from 'sentry/views/detectors/pathnames';

interface Props {
connectedIds: Automation['detectorIds'];
Expand Down Expand Up @@ -199,6 +202,8 @@ function ConnectMonitorsContent({
export default function EditConnectedMonitors({connectedIds, setConnectedIds}: Props) {
const ref = useRef<HTMLButtonElement>(null);
const {openDrawer, closeDrawer, isDrawerOpen} = useDrawer();
const organization = useOrganization();
const {monitorsLinkPrefix} = useMonitorViewContext();

const toggleDrawer = () => {
if (isDrawerOpen) {
Expand Down Expand Up @@ -237,9 +242,14 @@ export default function EditConnectedMonitors({connectedIds, setConnectedIds}: P
<Container>
<SelectedMonitors connectedIds={connectedIds} />
<ButtonWrapper justify="between">
<Button size="sm" icon={<IconAdd />} onClick={toggleDrawer}>
<LinkButton
size="sm"
icon={<IconAdd />}
href={makeMonitorCreatePathname(organization.slug, monitorsLinkPrefix)}
external
>
{t('Create New Monitor')}
</Button>
</LinkButton>
<Button size="sm" icon={<IconEdit />} onClick={toggleDrawer}>
{t('Edit Monitors')}
</Button>
Expand Down