Stone fence post

Refactoring
jasonsturges · Nov 21, 2024 · d47cdda · d47cdda
1 parent 387374d
commit d47cdda
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/examples/index.html b/examples/index.html
@@ -51,7 +51,7 @@ <h2>Models</h2>
         <div>
           <header>Fence</header>
           <ul>
-            <li><a href="/three-low-poly/models/fence/fence-column">Fence Column</a></li>
+            <li><a href="/three-low-poly/models/fence/stone-fence-post">Stone Fence Post</a></li>
             <li><a href="/three-low-poly/models/fence/wrought-iron-bar">Wrought Iron Bar</a></li>
             <li><a href="/three-low-poly/models/fence/wrought-iron-fence">Wrought Iron Fence</a></li>
           </ul>

diff --git a/examples/models/fence/fence-column.html → examples/models/fence/stone-fence-post.html b/examples/models/fence/fence-column.html → examples/models/fence/stone-fence-post.html
@@ -17,7 +17,7 @@
   <body>
     <script type="module">
       import GUI from "lil-gui";
-      import { centerMesh, FenceColumn } from "../../../src/index.js";
+      import { centerMesh, StoneFencePost } from "../../../src/index.js";
       import { createOrbitScene } from "../../utils/orbitScene.js";
 
       const { scene } = createOrbitScene();
@@ -27,7 +27,7 @@
         height: 2.25,
       };
 
-      let fenceColumn = new FenceColumn(params);
+      let fenceColumn = new StoneFencePost(params);
       scene.add(fenceColumn);
       centerMesh(fenceColumn);
 
@@ -37,7 +37,7 @@
 
       function update() {
         scene.remove(fenceColumn);
-        fenceColumn = new FenceColumn(params);
+        fenceColumn = new StoneFencePost(params);
         scene.add(fenceColumn);
         centerMesh(fenceColumn);
       }

diff --git a/examples/scenes/graveyard.html b/examples/scenes/graveyard.html
@@ -22,7 +22,6 @@
         Candle,
         CrossHeadstone,
         EllipticLeafGeometry,
-        FenceColumn,
         Lantern,
         LeafEffect,
         Mausoleum,
@@ -31,6 +30,7 @@
         Rocks,
         RoundedHeadstone,
         SquareHeadstone,
+        StoneFencePost,
         WroughtIronFence,
       } from "../../src/index.js";
       import { DoubleSide, MeshStandardMaterial } from "three";
@@ -93,15 +93,15 @@
       }
 
       // Fence
-      const stoneColumn = new FenceColumn();
+      const stoneFencePost = new StoneFencePost();
       const wroughtIronFence = new WroughtIronFence({ count: 15 });
       const enclosedFenceGroup = new THREE.Group();
       const sideLength = 4;
       const columnSpacing = 6;
 
       for (let side = 0; side < sideLength; side++) {
         for (let i = 0; i < sideLength; i++) {
-          const column = stoneColumn.clone();
+          const column = stoneFencePost.clone();
           const x = side === 1 || side === 3 ? i * columnSpacing : side === 0 ? 0 : (sideLength - 1) * columnSpacing;
           const z = side === 0 || side === 2 ? i * columnSpacing : side === 1 ? (sideLength - 1) * columnSpacing : 0;
           column.position.set(x, 0, z);

diff --git a/src/index.ts b/src/index.ts
@@ -124,7 +124,7 @@ export { RoundedHeadstone } from "./models/cemetery/RoundedHeadstone";
 export { SquareHeadstone } from "./models/cemetery/SquareHeadstone";
 
 // Fence
-export { FenceColumn } from "./models/fence/FenceColumn";
+export { StoneFencePost } from "./models/fence/StoneFencePost";
 export { WroughtIronBar } from "./models/fence/WroughtIronBar";
 export { WroughtIronFence } from "./models/fence/WroughtIronFence";
 

diff --git a/src/models/fence/FenceColumn.ts → src/models/fence/StoneFencePost.ts b/src/models/fence/FenceColumn.ts → src/models/fence/StoneFencePost.ts
@@ -1,7 +1,7 @@
 import { Mesh, MeshStandardMaterial } from "three";
 import { StoneFencePostGeometry } from "../../geometry/fence/StoneFencePostGeometry";
 
-export class FenceColumn extends Mesh<StoneFencePostGeometry, MeshStandardMaterial> {
+export class StoneFencePost extends Mesh<StoneFencePostGeometry, MeshStandardMaterial> {
   constructor({ height = 2.25 } = {}) {
     super(
       new StoneFencePostGeometry({ height }),