fixed moment-with-locales.js path issue #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated the moment and moment-timezone package versions
|
@jasonmit Could you please review this one? |
|
Hi @jasonmit , |
|
@AThiyagarajan I no longer have any way to test changes here and hesitate to merge anything without a way to validate it. The best path forward for users of this addon is to follow the guide at https://github.com/adopted-ember-addons/ember-moment#using-momentjs-in-ember-apps--addons and remove this addon from your build entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent versions of moment the path has been updated.
This PR fixes the moment-with-locales.js path issue
Also updated the
momentandmoment-timezonepackage versions