feat(positions-enum): add a static positions property on the Popover component #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using this component, we have an object that basically serves as an
enum
for the various position preferences we might need for differentPopover
use-cases.I was hoping of adding this
enum
as part of the public API for this library.Where To Add The
enum
I noticed that this library has a single
module.exports
value (thePopover
component) which is why I went with thestatic
property onPopover
directly vs. adding a named property on themodule.exports
object that would reference thePOSITIONS
enum object (my understanding is that doing something likemodule.exports.POSITIONS = lib.POSITIONS
would effectively be like adding thestatic
property anyways sincemodule.exports
would reference the exportedPopover
component).Testing Modifications (i.e.
Storybook
)I modified the underlying
Storybook
stories to use the newPOSITIONS
enum (exported fromlayout.js
) to sanity check my changes.Feel free to modify the naming pattern for the
enum
- I've just seen a general pattern ofUPCASE
enum names andUPCASE
for the underlying property names