Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow linebreak/indent before param default #5278

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow linebreak/indent before param default #5278

wants to merge 1 commit into from

Conversation

helixbass
Copy link
Collaborator

@GeoffreyBooth re-opening against master

See original PR: #5081

@helixbass helixbass mentioned this pull request Dec 30, 2019
Closed
edemaine
edemaine reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@edemaine edemaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea to me; it matches the rule of Assign.

(Hope you don't mind the necro.)

@GeoffreyBooth
Copy link
Collaborator

This seems like a good idea to me; it matches the rule of Assign.

(Hope you don’t mind the necro.)

Yes, it’s fine, do you mind rebasing against latest main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edemaine edemaine edemaine left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helixbass @GeoffreyBooth @edemaine