Replace use of dprintf() with fprintf() or write() #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves compatibility with legacy platforms that don't provide the function, in particular, Illumos.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jarun
requested changes
Jul 17, 2024
jarun
requested changes
Jul 19, 2024
| @@ -2843,7 +2843,8 @@ static void write_lastdir(const char *curpath, const char *outfile) | |||
| : cfgpath, O_CREAT | O_WRONLY | O_TRUNC, S_IWUSR | S_IRUSR); | |||
|
|
|||
| if (fd != -1 && shell_escape(g_buf, sizeof(g_buf), curpath)) { | |||
| dprintf(fd, "cd %s", g_buf); | |||
| write(fd, "cd ", 3); | |||
There was a problem hiding this comment.
Please check the return value of write. CI fails with the following:
########## gcc-9 ##########
gcc-9 -Werror -std=c11 -Wall -Wextra -Wshadow -O3 -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -o nnn src/nnn.c -lreadline -lncursesw -ltinfo -lpthread
src/nnn.c: In function 'write_lastdir':
src/nnn.c:2846:3: error: ignoring return value of 'write', declared with attribute warn_unused_result [-Werror=unused-result]
2846 | write(fd, "cd ", 3);
| ^~~~~~~~~~~~~~~~~~~
src/nnn.c:2847:3: error: ignoring return value of 'write', declared with attribute warn_unused_result [-Werror=unused-result]
2847 | write(fd, g_buf, strlen(g_buf));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [Makefile:224: nnn] Error 1
Exited with code exit status 2
jarun
requested changes
Jul 19, 2024
| else | ||
| bitmap[key] = TRUE; | ||
| } | ||
| } | ||
|
|
||
| static void usage(void) | ||
| { | ||
| dprintf(STDOUT_FILENO, | ||
| printf( |
| @@ -8716,7 +8717,7 @@ int main(int argc, char *argv[]) | |||
| g_state.uidgid = 1; | |||
| break; | |||
| case 'V': | |||
| dprintf(STDOUT_FILENO, "%s\n", VERSION); | |||
| printf("%s\n", VERSION); | |||
|
Any update here? |
|
Merging. I'll take care of the rest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves compatibility with legacy platforms that don't provide the function, in particular, Illumos.
(Alternative to #1911)