Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add megapixel target functionality #62

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Add megapixel target functionality #62

merged 1 commit into from
Jan 25, 2025

Conversation

r41d
Copy link
Contributor

@r41d r41d commented Jan 15, 2025

I wanted to be able to ensure that all images in a folder have a specified megapixel count at max, hence this implementation

Removed global where it's not needed, according to: https://stackoverflow.com/a/4693385

@r41d
Copy link
Contributor Author

r41d commented Jan 19, 2025

Any feedback is appreciated :)

@jarun
Copy link
Owner

jarun commented Jan 19, 2025

I'll check.
Can you please squash the commits into one?

@r41d
Copy link
Contributor Author

r41d commented Jan 19, 2025

I'll check. Can you please squash the commits into one?

Done

CHANGELOG Outdated Show resolved Hide resolved
imgp Outdated Show resolved Hide resolved
imgp Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@r41d
Copy link
Contributor Author

r41d commented Jan 21, 2025

Feedback incorporated.

@jarun
Copy link
Owner

jarun commented Jan 21, 2025

Please update the man page as well (features as well as option related changes).

@r41d
Copy link
Contributor Author

r41d commented Jan 21, 2025

How is the manpage done exactly? It looks like it's automatically generated from the Readme or am I mistaken?

@jarun
Copy link
Owner

jarun commented Jan 21, 2025

No, it's updated separately. Just keep things same as readme wherever possible.

@r41d
Copy link
Contributor Author

r41d commented Jan 21, 2025

Ah. I thought there was a way. Tried to incorporate everything by hand

README.md Outdated Show resolved Hide resolved
imgp.1 Outdated Show resolved Hide resolved
@jarun jarun merged commit b034889 into jarun:master Jan 25, 2025
1 check passed
@jarun
Copy link
Owner

jarun commented Jan 25, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants