-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add Users In Doc Changed #4036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Users In Doc Changed #4036
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe code updates the branch reference in the "editUrl" constant within the users page, changing it from "master" to "main" in the URL that links to the repository's source file editor. No other logic, structure, or exported entities are altered. Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
website/src/pages/users.tsx (1)
17-17
: DRY up the URL & avoid hard-coding the branch nameGreat catch updating the branch to
main
.
However, we’re now duplicating both the branch segment and the repo base in several places (siteConfig.editUrl
already contains…/edit/main
). This makes future branch renames or URL tweaks easy to miss.Consider deriving from the central constant instead:
- const editUrl = `${siteConfig.repoUrl}/edit/main/website/src/users.ts`; + const editUrl = `${siteConfig.editUrl}/website/src/users.ts`;This keeps the branch name authoritative in one place (
siteConfig
) and eliminates string repetition.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
website/src/pages/users.tsx
(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
website/src/pages/users.tsx (1)
website/src/siteConfig.tsx (1)
siteConfig
(3-17)
When Clicked on Add your company redirected to a 404 in master so changed it to main
Summary by CodeRabbit