Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use safe version of xmldom and mocha #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ncluer
Copy link

@ncluer ncluer commented Jun 18, 2024

** READ THIS FIRST! **

Are you implementing a new feature?

n/a

Is this a security patch?

Removes dependency on xtraverse and uses safer version of xmldom to handle the fallback in parseErrorResponse.

Updates mocha to safe version with no critical vulnerabilites.

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have added test cases which verify the correct operation of this feature or patch.
  • I have added documentation pertaining to this feature or patch.
  • The automated test suite ($ make test) executes successfully.
  • The automated code linting ($ make lint) executes successfully.

@RobinTail
Copy link

@jaredhanson please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants