Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix waila (jade) integration #1107

Open
wants to merge 2 commits into
base: 1.20
Choose a base branch
from
Open

Conversation

dima-dencep
Copy link

When using jade, you may get an error when loading minecraft:

Error loading plugin at com.jaquadro.minecraft.storagedrawers.integration.Waila
java.lang.NullPointerException
	at java.base/java.util.Objects.requireNonNull(Objects.java:209)
	at TRANSFORMER/[email protected]/snownee.jade.impl.HierarchyLookup.register(HierarchyLookup.java:39)
	at TRANSFORMER/[email protected]/snownee.jade.impl.WailaClientRegistration.registerBlockComponent(WailaClientRegistration.java:105)
	at TRANSFORMER/[email protected]/com.jaquadro.minecraft.storagedrawers.integration.Waila.registerClient(Waila.java:28)
	at TRANSFORMER/[email protected]/snownee.jade.util.CommonProxy.loadComplete(CommonProxy.java:143)
	at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:260)
	at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:252)
	at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:315)
	at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:296)
	at LAYER PLUGIN/[email protected]/net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:107)
	at LAYER PLUGIN/[email protected]/net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$10(ModContainer.java:124)
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804)
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

This pr fixes this

@Sultia
Copy link

Sultia commented Nov 28, 2023

bump

@Mickeon
Copy link

Mickeon commented May 16, 2024

Massive bump. I've noticed this bug, as well, and I was about to open a bug report in Jade's repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants