Add Prometheus AlertManager alert provider with full test coverage#592
Open
bosmanx wants to merge 1 commit intojantman:developfrom
Open
Add Prometheus AlertManager alert provider with full test coverage#592bosmanx wants to merge 1 commit intojantman:developfrom
bosmanx wants to merge 1 commit intojantman:developfrom
Conversation
- Add AlertManager class supporting single/multiple endpoints - Support environment variables and parameters for configuration - Add basic authentication support - Implement 16 comprehensive tests covering all functionality - Fix optional endpoints parameter (was incorrectly required) Based on PR jantman#515 by varuzam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive test coverage to complete PR #515 by @varuzam.
The original PR #515 implements the AlertManager alert provider with support for:
This PR adds the missing unit tests (16 comprehensive tests) to allow the feature to be merged.
Minor fix:
endpointsparameter was incorrectly required in__init__- now properly optional when using environment variables.Pull Request Checklist
tox -e docs(requires Python 3.9, will be handled by CI)Contributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms:
is being made under the same license as the awslimitchecker project (the Affero GPL v3,
or any subsequent version of that license if adopted by awslimitchecker).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of awslimitchecker's license.