Skip to content

Conversation

@bosmanx
Copy link

@bosmanx bosmanx commented Nov 5, 2025

Summary

Fix "Units set to "None"" error when retrieving RDS "Total storage for all DB instances" quota from Service Quotas. AWS changed the quota unit from "Gigabytes" to "None" without announcement, similar to the ELB issue fixed in #503. This PR adds a unit converter that accepts both "Gigabytes" and "None" units.

Pull Request Checklist

  • All pull requests should be against the develop branch, not master.
  • All pull requests must include the Contributor License Agreement (see below).
  • Whether or not your PR includes unit tests:
    • Please make sure you have run the exact code contained in the PR locally, and it functions as desired.
    • Please make sure the TravisCI build passes or, if not, you've corrected any obvious problems identified by the tests.
  • Code should conform to the Development Guidelines:
    • pep8 compliant with some exceptions (see pytest.ini)
    • 100% test coverage with pytest (with valid tests) - all 12 tests passing
    • Complete, correctly-formatted documentation for all classes, functions and methods.
    • documentation has been rebuilt with tox -e docs - unable to run locally due to Python 3.9 vs 3.11 version mismatch, but no documentation structure changes were made
    • Connections to the AWS services use proper methods
    • All modules have module-level loggers.
    • Commit messages are meaningful
    • Git history is fully intact; no squashing or rewriting.

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the awslimitchecker project (the Affero GPL v3,
    or any subsequent version of that license if adopted by awslimitchecker).
  • My contribution may perpetually be included in and distributed with awslimitchecker; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of awslimitchecker's license.
  • I have the legal power and rights to agree to these terms.

Kamil Christ added 2 commits November 5, 2025 10:53
Introduced a new function to handle the conversion of RDS storage limits from "Gigabytes" to "None" due to AWS's change in quota units. Updated the _RDSService class to utilize this converter and added corresponding unit tests to ensure functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant