Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new api docs #48

Merged
merged 5 commits into from
Apr 24, 2018
Merged

add new api docs #48

merged 5 commits into from
Apr 24, 2018

Conversation

shaunlebron
Copy link
Contributor

@shaunlebron shaunlebron commented Apr 23, 2018

Preview the new markdown API doc here

This PR also redirects the original api page to it.

<script>
// Redirect to new API documentation page:
window.location.replace("https://github.com/janpaul123/paperprograms/blob/master/docs/api.md");
</script>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just delete this page entirely and link directly to https://github.com/janpaul123/paperprograms/blob/master/docs/api.md from the editor page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we could do this to avoid dead links, yeah?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, though I doubt that many people will have this bookmarked since it's right there on the editor page. Let's at least then also update the link though, no need to link to an old page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, maybe I'm on the only one who bookmarked it. just updated the editor link 👍

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/api.md Outdated
colorName // "red", "green", "blue" or "black"

// these properties will be null if the marker is not on a paper
paperId,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only noticing this now, but should we call this paperNumber for consistency? (This is outside the scope of this PR though, and no biggie anyway)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I pulled this from #43 (comment), but it looks like it was not implemented. fixed the name, and tagged as wip.

Copy link
Owner

@janpaul123 janpaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, looks good overall! I'll merge when addressed 👍

@janpaul123 janpaul123 merged commit 8bd5d15 into janpaul123:master Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants