-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
I believe we can do "better" than this in some cases but I'm going with this for graceful-degradataion-v1
- Loading branch information
There are no files selected for viewing
3 comments
on commit cb9d58b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was imagining it being possible to have detailed tx data displayed inline on /address/xxx
for some of the transactions (e.g. recent ones), but the UX for displaying some-but-not-all could be chaotic so I'm unsure whether it's the right choice.
I agree with your addition here and I made that change.
I'm also curious your thoughts on this change. I see some value in giving something in cases where a user, with pruning active or no txindex, clicks through to a /tx/
page from a /address
page. It's a bit of a hack - you could alter the URL to use a different blockHeight and the tool would gladly display the height/date for that block - but it gives some helpful context in some situations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could alter the URL to use a different blockHeight and the tool would gladly display the height/date for that block
Wouldn't a block height that doesn't match the txid result in coreApi.getRawTransactionsWithInputs([txid], -1, block.hash)
failing and returning an error message to the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, coreApi.getRawTransactionsWithInputs
fails, but that happens anyway if the block containing the tx has been pruned; since we "expect" the error, it's handled more gracefully than it would be in, say, a non-pruned environment.
Looks like this just needs
`@${addressDetails.blockHeightsByTxid[txid]}`
(when >0) tucked at the end of the link to work without txindex? :-)What did you have in mind for graceful-degradataion-v2?