fix(string-seq): considers index for equality check and hash generation

compiler+runtime/include/cpp/jank/native_persistent_string.hpp

@@ -52,7 +52,6 @@ namespace jank
     using const_iterator = const_pointer_type;
     using reverse_iterator = std::reverse_iterator<iterator>;
     using const_reverse_iterator = std::reverse_iterator<const_iterator>;
-    using difference_type = std::ptrdiff_t;
 
     static constexpr size_type npos{ std::numeric_limits<size_type>::max() };
 

compiler+runtime/include/cpp/jank/runtime/detail/type.hpp

@@ -12,7 +12,7 @@
 
 namespace jank::runtime::detail
 {
-  bool equal(char const lhs, object_ptr const rhs);
+  native_bool equal(char const lhs, object_ptr const rhs);
   native_bool equal(object_ptr const lhs, object_ptr const rhs);
 
   struct object_ptr_equal

compiler+runtime/src/cpp/jank/runtime/detail/object_util.cpp

@@ -35,18 +35,18 @@ namespace jank::runtime::detail
       o);
   }
 
-  bool equal(char const lhs, object_ptr const rhs)
+  native_bool equal(char const lhs, object_ptr const rhs)
   {
     if(!rhs || rhs->type != object_type::character)
     {
       return false;
     }
 
     auto const typed_rhs = expect_object<obj::character>(rhs);
-    return typed_rhs->to_hash() == static_cast<unsigned int>(lhs);
+    return typed_rhs->to_hash() == static_cast<native_hash>(lhs);
   }
 
-  bool equal(object_ptr const lhs, object_ptr const rhs)
+  native_bool equal(object_ptr const lhs, object_ptr const rhs)
   {
     if(!lhs)
     {
@@ -75,7 +75,7 @@ namespace std
   }
 
   // NOLINTNEXTLINE(bugprone-exception-escape): TODO: Sort this out.
-  bool equal_to<jank::runtime::object_ptr>::operator()(
+  jank::native_bool equal_to<jank::runtime::object_ptr>::operator()(
     jank::runtime::object_ptr const lhs,
     jank::runtime::object_ptr const rhs) const noexcept
   {

compiler+runtime/src/cpp/jank/runtime/obj/persistent_string_sequence.cpp

@@ -18,7 +18,7 @@ namespace jank::runtime
   /* behavior::objectable */
   native_bool obj::persistent_string_sequence::equal(object const &o) const
   {
-    return detail::equal(o, str->data.begin(), str->data.end());
+    return detail::equal(o, str->data.begin() + index, str->data.end());
   }
 
   void obj::persistent_string_sequence::to_string(fmt::memory_buffer &buff) const
@@ -35,7 +35,7 @@ namespace jank::runtime
 
   native_hash obj::persistent_string_sequence::to_hash() const
   {
-    return hash::ordered(str->data.begin(), str->data.end());
+    return hash::ordered(str->data.begin() + index, str->data.end());
   }
 
   /* behavior::countable */
@@ -71,7 +71,7 @@ namespace jank::runtime
       return nullptr;
     }
 
-    return jank::make_box<obj::persistent_string_sequence>(str, n);
+    return make_box<obj::persistent_string_sequence>(str, n);
   }
 
   obj::persistent_string_sequence_ptr obj::persistent_string_sequence::next_in_place()

compiler+runtime/src/cpp/jank/runtime/obj/persistent_vector_sequence.cpp

@@ -18,7 +18,11 @@ namespace jank::runtime
   /* behavior::objectable */
   native_bool obj::persistent_vector_sequence::equal(object const &o) const
   {
-    return detail::equal(o, vec->data.begin(), vec->data.end());
+    return detail::equal(
+      o,
+      vec->data.begin()
+        + static_cast<decltype(obj::persistent_vector::data)::difference_type>(index),
+      vec->data.end());
   }
 
   void obj::persistent_vector_sequence::to_string(fmt::memory_buffer &buff) const
@@ -47,13 +51,16 @@ namespace jank::runtime
 
   native_hash obj::persistent_vector_sequence::to_hash() const
   {
-    return hash::ordered(vec->data.begin(), vec->data.end());
+    return hash::ordered(
+      vec->data.begin()
+        + static_cast<decltype(obj::persistent_vector::data)::difference_type>(index),
+      vec->data.end());
   }
 
   /* behavior::countable */
   size_t obj::persistent_vector_sequence::count() const
   {
-    return vec->data.size();
+    return vec->data.size() - index;
   }
 
   /* behavior::seqable */
@@ -64,7 +71,7 @@ namespace jank::runtime
 
   obj::persistent_vector_sequence_ptr obj::persistent_vector_sequence::fresh_seq() const
   {
-    return jank::make_box<obj::persistent_vector_sequence>(vec, index);
+    return make_box<obj::persistent_vector_sequence>(vec, index);
   }
 
   /* behavior::sequenceable */
@@ -83,7 +90,7 @@ namespace jank::runtime
       return nullptr;
     }
 
-    return jank::make_box<obj::persistent_vector_sequence>(vec, n);
+    return make_box<obj::persistent_vector_sequence>(vec, n);
   }
 
   obj::persistent_vector_sequence_ptr obj::persistent_vector_sequence::next_in_place()