test conj #768
Open
test conj #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeaye
requested changes
Oct 24, 2025
| [clojure.core-test.portability #?(:cljs :refer-macros :default :refer) [when-var-exists]])) | ||
|
|
||
| (when-var-exists conj | ||
| (deftest test-conj |
There was a problem hiding this comment.
I think we can have a test for adding to the front of an infinite seq. For example (conj (range) -1)) is valid.
| (is (= '(\f \e \d \a \b \c) (conj '(\a \b \c) \d \e \f))) | ||
| (is (= [[1 2] [3 4] [5 6]] (conj [[1 2] [3 4]] [5 6]))) | ||
| (is (= {:a 0 :b 1} (conj {:a 0} [:b 1]))) | ||
| (is (= {:a 0 :b 1} (conj {:a 0} {:b 1}))) |
There was a problem hiding this comment.
Existing map keys can also be updated. (conj {:a 0} {:a 1}), for example.
| (is (thrown? js/Error (conj :a :b))) | ||
| (is (thrown? js/Error (conj {:a 0} '(:b 1))))] | ||
|
|
||
| :default [(is (thrown? Exception (conj "a" "b"))) |
There was a problem hiding this comment.
I didn't include one because in cljs a character is a string, so the test (is (thrown? js/Error (conj \a \b))) basically covers strings as well. Another test with strings seemed a bit redundant, but I can include it if you want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #201