test mapcat (#354)
#762
test mapcat (#354)
#762
Conversation
| (testing "function sometimes returns []" | ||
| (is (= [1 3 5] (mapcat #(if (odd? %) [%] []) (range 1 6))))) | ||
| (testing "function sometimes returns nil" | ||
| (is (= [2 4] (mapcat #(if (even? %) [%] nil) (range 1 5))))) |
There was a problem hiding this comment.
mapcat has a variadic arity, which we should test by passing many sequences. The most we're doing, in these tests, is two sequences.
|
Thanks for both of y'all's work! I'll take a look tonight |
|
|
||
|
|
||
| (when-var-exists mapcat | ||
| (deftest common-cases |
There was a problem hiding this comment.
nitpick but why isn't the test name based on the var it's testing?
| (mapcat identity 5)))) | ||
| (testing "non-function first arg" | ||
| (is (thrown? #?(:cljs :default :clj Exception :cljr Exception) | ||
| (mapcat 42 [1 2])))))) |
There was a problem hiding this comment.
I'd add one more negative test for when the result of mapping isn't a concatable data structure, e.g.
(mapcat identity (range 2))
;; => Exception
|
@gavlooth if you're busy I don't mind making the changes, just would need write access to push to your fork |
Want to spin up a PR based on this branch to address the feedback? |
4 participants
No description provided.