Skip to content

Disable file search by default #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
locnguyen1986 merged 2 commits into from
Dec 17, 2025
Merged

Disable file search by default #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeec8bf
disable file search by default
locnguyen1986 Dec 17, 2025
499677e
Merge pull request #310 from janhq/feat/disable-file-search
locnguyen1986 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ VECTOR_STORE_URL=http://vector-store:3015
# SANDBOX_FUSION_REQUIRE_APPROVAL=true
MCP_ENABLE_PYTHON_EXEC=true
MCP_ENABLE_MEMORY_RETRIEVE=true
MCP_ENABLE_FILE_SEARCH=false

# Browser automation & code execution
# CODE_SANDBOX_ENABLED=true
Expand Down
1 change: 1 addition & 0 deletions services/mcp-tools/internal/infrastructure/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ type Config struct {
SandboxFusionRequireApproval bool `env:"MCP_SANDBOX_REQUIRE_APPROVAL" envDefault:"false"`
EnablePythonExec bool `env:"MCP_ENABLE_PYTHON_EXEC" envDefault:"true"`
EnableMemoryRetrieve bool `env:"MCP_ENABLE_MEMORY_RETRIEVE" envDefault:"true"`
EnableFileSearch bool `env:"MCP_ENABLE_FILE_SEARCH" envDefault:"false"`
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new MCP_ENABLE_FILE_SEARCH environment variable should be documented in the README.md file under the External Services section, similar to how MCP_ENABLE_PYTHON_EXEC and MCP_ENABLE_MEMORY_RETRIEVE are documented at lines 168-169. This will help users understand how to configure this feature.

Copilot uses AI. Check for mistakes.

// Authentication
AuthEnabled bool `env:"AUTH_ENABLED" envDefault:"false"`
Expand Down
287 changes: 147 additions & 140 deletions services/mcp-tools/internal/interfaces/httpserver/routes/mcp/serper_mcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,15 @@ type SerperMCP struct {
maxSnippetChars int
maxScrapePreviewChars int
maxScrapeTextChars int
enableFileSearch bool
}

// SerperMCPConfig contains configuration for SerperMCP.
type SerperMCPConfig struct {
MaxSnippetChars int
MaxScrapePreviewChars int
MaxScrapeTextChars int
EnableFileSearch bool
}

// NewSerperMCP creates a new search MCP handler.
Expand All @@ -141,6 +143,7 @@ func NewSerperMCP(searchService *domainsearch.SearchService, vectorStore *vector
maxSnippetChars: maxSnippet,
maxScrapePreviewChars: maxPreview,
maxScrapeTextChars: maxText,
enableFileSearch: cfg.EnableFileSearch,
}
}

Expand Down Expand Up @@ -388,162 +391,166 @@ func (s *SerperMCP) RegisterTools(server *mcp.Server) {
return nil, payload, nil
})

// Disabled: file_search_index and file_search_query tools
mcp.AddTool(server, &mcp.Tool{
Name: "file_search_index",
Description: "Index arbitrary text into the lightweight vector store used for MCP automations.",
}, func(ctx context.Context, req *mcp.CallToolRequest, input FileSearchIndexArgs) (*mcp.CallToolResult, map[string]any, error) {
startTime := time.Now()
callCtx := extractAllContext(req)
log.Info().
Str("tool", "file_search_index").
Str("tool_call_id", callCtx["tool_call_id"]).
Str("request_id", callCtx["request_id"]).
Str("conversation_id", callCtx["conversation_id"]).
Str("user_id", callCtx["user_id"]).
Msg("MCP tool call received")

status := "success"
var tokens float64

if s.vectorStore != nil && s.vectorStore.IsEnabled() {
resp, err := s.vectorStore.IndexDocument(ctx, vectorstore.IndexRequest{
DocumentID: input.DocumentID,
Text: input.Text,
Metadata: input.Metadata,
Tags: input.Tags,
})
if err == nil {
tokens = float64(resp.TokenCount)
metrics.RecordToolCall("file_search_index", "vectorstore", status, time.Since(startTime).Seconds())
if tokens > 0 {
metrics.RecordToolTokens("file_search_index", "vectorstore", tokens)
// file_search_index and file_search_query tools (conditionally enabled)
if !s.enableFileSearch {
log.Warn().Msg("file_search_index and file_search_query MCP tools disabled via config")
} else {
mcp.AddTool(server, &mcp.Tool{
Name: "file_search_index",
Description: "Index arbitrary text into the lightweight vector store used for MCP automations.",
}, func(ctx context.Context, req *mcp.CallToolRequest, input FileSearchIndexArgs) (*mcp.CallToolResult, map[string]any, error) {
startTime := time.Now()
callCtx := extractAllContext(req)
log.Info().
Str("tool", "file_search_index").
Str("tool_call_id", callCtx["tool_call_id"]).
Str("request_id", callCtx["request_id"]).
Str("conversation_id", callCtx["conversation_id"]).
Str("user_id", callCtx["user_id"]).
Msg("MCP tool call received")

status := "success"
var tokens float64

if s.vectorStore != nil && s.vectorStore.IsEnabled() {
resp, err := s.vectorStore.IndexDocument(ctx, vectorstore.IndexRequest{
DocumentID: input.DocumentID,
Text: input.Text,
Metadata: input.Metadata,
Tags: input.Tags,
})
if err == nil {
tokens = float64(resp.TokenCount)
metrics.RecordToolCall("file_search_index", "vectorstore", status, time.Since(startTime).Seconds())
if tokens > 0 {
metrics.RecordToolTokens("file_search_index", "vectorstore", tokens)
}
return nil, map[string]any{
"document_id": resp.DocumentID,
"status": resp.Status,
"indexed_at": resp.IndexedAt,
"token_count": resp.TokenCount,
}, nil
}
return nil, map[string]any{
"document_id": resp.DocumentID,
"status": resp.Status,
"indexed_at": resp.IndexedAt,
"token_count": resp.TokenCount,
}, nil
log.Warn().Err(err).Str("tool", "file_search_index").Msg("vector store index failed; falling back to stub")
status = "error"
}
log.Warn().Err(err).Str("tool", "file_search_index").Msg("vector store index failed; falling back to stub")
status = "error"
}

s.fileIndexMu.Lock()
s.fileIndex[input.DocumentID] = input
s.fileIndexMu.Unlock()

tokens = float64(len(input.Text)) / 4
metrics.RecordToolCall("file_search_index", "vectorstore", status, time.Since(startTime).Seconds())
if tokens > 0 {
metrics.RecordToolTokens("file_search_index", "vectorstore", tokens)
}

return nil, map[string]any{
"document_id": input.DocumentID,
"status": "indexed",
"indexed_at": time.Now().UTC().Format(time.RFC3339),
"token_count": len(input.Text),
}, nil
})

mcp.AddTool(server, &mcp.Tool{
Name: "file_search_query",
Description: "Run a semantic query against documents indexed via file_search_index.",
}, func(ctx context.Context, req *mcp.CallToolRequest, input FileSearchQueryArgs) (*mcp.CallToolResult, map[string]any, error) {
startTime := time.Now()
callCtx := extractAllContext(req)
log.Info().
Str("tool", "file_search_query").
Str("tool_call_id", callCtx["tool_call_id"]).
Str("request_id", callCtx["request_id"]).
Str("conversation_id", callCtx["conversation_id"]).
Str("user_id", callCtx["user_id"]).
Msg("MCP tool call received")
s.fileIndexMu.Lock()
s.fileIndex[input.DocumentID] = input
s.fileIndexMu.Unlock()

status := "success"
var tokens float64
tokens = float64(len(input.Text)) / 4
metrics.RecordToolCall("file_search_index", "vectorstore", status, time.Since(startTime).Seconds())
if tokens > 0 {
metrics.RecordToolTokens("file_search_index", "vectorstore", tokens)
}

topK := 5
if input.TopK != nil && *input.TopK > 0 {
topK = *input.TopK
}
if topK > 20 {
topK = 20
}
return nil, map[string]any{
"document_id": input.DocumentID,
"status": "indexed",
"indexed_at": time.Now().UTC().Format(time.RFC3339),
"token_count": len(input.Text),
}, nil
})

mcp.AddTool(server, &mcp.Tool{
Name: "file_search_query",
Description: "Run a semantic query against documents indexed via file_search_index.",
}, func(ctx context.Context, req *mcp.CallToolRequest, input FileSearchQueryArgs) (*mcp.CallToolResult, map[string]any, error) {
startTime := time.Now()
callCtx := extractAllContext(req)
log.Info().
Str("tool", "file_search_query").
Str("tool_call_id", callCtx["tool_call_id"]).
Str("request_id", callCtx["request_id"]).
Str("conversation_id", callCtx["conversation_id"]).
Str("user_id", callCtx["user_id"]).
Msg("MCP tool call received")

status := "success"
var tokens float64

topK := 5
if input.TopK != nil && *input.TopK > 0 {
topK = *input.TopK
}
if topK > 20 {
topK = 20
}

if s.vectorStore != nil && s.vectorStore.IsEnabled() {
resp, err := s.vectorStore.Query(ctx, vectorstore.QueryRequest{
Text: input.Query,
TopK: topK,
DocumentIDs: input.DocumentIDs,
})
if err == nil {
for _, r := range resp.Results {
tokens += float64(len(r.TextPreview)) / 4
}
metrics.RecordToolCall("file_search_query", "vectorstore", status, time.Since(startTime).Seconds())
if tokens > 0 {
metrics.RecordToolTokens("file_search_query", "vectorstore", tokens)
if s.vectorStore != nil && s.vectorStore.IsEnabled() {
resp, err := s.vectorStore.Query(ctx, vectorstore.QueryRequest{
Text: input.Query,
TopK: topK,
DocumentIDs: input.DocumentIDs,
})
if err == nil {
for _, r := range resp.Results {
tokens += float64(len(r.TextPreview)) / 4
}
metrics.RecordToolCall("file_search_query", "vectorstore", status, time.Since(startTime).Seconds())
if tokens > 0 {
metrics.RecordToolTokens("file_search_query", "vectorstore", tokens)
}
return nil, map[string]any{
"query": resp.Query,
"top_k": resp.TopK,
"count": resp.Count,
"results": resp.Results,
}, nil
}
return nil, map[string]any{
"query": resp.Query,
"top_k": resp.TopK,
"count": resp.Count,
"results": resp.Results,
}, nil
log.Warn().Err(err).Str("tool", "file_search_query").Msg("vector store query failed; falling back to stub")
status = "error"
}
log.Warn().Err(err).Str("tool", "file_search_query").Msg("vector store query failed; falling back to stub")
status = "error"
}

s.fileIndexMu.Lock()
defer s.fileIndexMu.Unlock()
results := make([]map[string]any, 0)
for docID, doc := range s.fileIndex {
if len(input.DocumentIDs) > 0 {
match := false
for _, allowed := range input.DocumentIDs {
if allowed == docID {
match = true
break
s.fileIndexMu.Lock()
defer s.fileIndexMu.Unlock()
results := make([]map[string]any, 0)
for docID, doc := range s.fileIndex {
if len(input.DocumentIDs) > 0 {
match := false
for _, allowed := range input.DocumentIDs {
if allowed == docID {
match = true
break
}
}
if !match {
continue
}
}
if !match {
continue
preview := truncateSnippet(doc.Text, 200)
results = append(results, map[string]any{
"document_id": docID,
"text_preview": preview,
"score": 1.0,
"metadata": doc.Metadata,
"tags": doc.Tags,
})
if len(results) >= topK {
break
}
}
preview := truncateSnippet(doc.Text, 200)
results = append(results, map[string]any{
"document_id": docID,
"text_preview": preview,
"score": 1.0,
"metadata": doc.Metadata,
"tags": doc.Tags,
})
if len(results) >= topK {
break
}
}

for _, r := range results {
if preview, ok := r["text_preview"].(string); ok {
tokens += float64(len(preview)) / 4
for _, r := range results {
if preview, ok := r["text_preview"].(string); ok {
tokens += float64(len(preview)) / 4
}
}
metrics.RecordToolCall("file_search_query", "vectorstore", status, time.Since(startTime).Seconds())
if tokens > 0 {
metrics.RecordToolTokens("file_search_query", "vectorstore", tokens)
}
}
metrics.RecordToolCall("file_search_query", "vectorstore", status, time.Since(startTime).Seconds())
if tokens > 0 {
metrics.RecordToolTokens("file_search_query", "vectorstore", tokens)
}

return nil, map[string]any{
"query": input.Query,
"top_k": topK,
"count": len(results),
"results": results,
}, nil
})
return nil, map[string]any{
"query": input.Query,
"top_k": topK,
"count": len(results),
"results": results,
}, nil
})
} // end if enableFileSearch
}

func (s *SerperMCP) buildSearchPayload(query string, req domainsearch.SearchRequest, resp *domainsearch.SearchResponse) searchToolPayload {
Expand Down
1 change: 1 addition & 0 deletions services/mcp-tools/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ func main() {
MaxSnippetChars: cfg.MaxSnippetChars,
MaxScrapePreviewChars: cfg.MaxScrapePreviewChars,
MaxScrapeTextChars: cfg.MaxScrapeTextChars,
EnableFileSearch: cfg.EnableFileSearch,
})

// Initialize memory MCP
Expand Down
Loading