Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting in README #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Spencer-Comin
Copy link

I just added a newline.

Before this change the example code block in the "Matching behavior" section rendered incorrectly. This caused the </details> end tag to be misinterpreted as part of a codeblock, which then caused the incorrectly rendered codeblock and the rest of the document following to be collapsed under "Expand examples".

@Spencer-Comin
Copy link
Author

Didn't think to check the other PRs before submitting my own. This solves the same problem as #53. I'd close this PR, but I'm partial to my solution given it's smaller.

@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Apr 29, 2024
@GitFenixZ
Copy link

GitFenixZ commented Apr 29, 2024

Your solution is perfect ! Don't forget to Sign off your commit to pass the check.

@Spencer-Comin
Copy link
Author

I did sign off my commit, but it looks like I didn't give the email GH expected.

Signed-off-by: Spencer Comin <[email protected]>
@Spencer-Comin
Copy link
Author

Not sure how to convince GH to accept my email instead of the autogenerated address, but the sign-off line is there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants